<html>
<head><meta charset="utf-8"><title>rustfix multi-span · edition 2021 · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/index.html">edition 2021</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/rustfix.20multi-span.html">rustfix multi-span</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="230357964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/rustfix%20multi-span/near/230357964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/rustfix.20multi-span.html#230357964">(Mar 15 2021 at 14:56)</a>:</h4>
<p>Right now, <a href="https://github.com/rust-lang/rust/pull/82113">the <code>non_fmt_panic</code> lint</a> for 2021's panic produces suggestions with multiple span+replacements. rustfix/cargo fix doesn't support that because of <a href="https://github.com/rust-lang/rust/issues/53934">#53934</a>, but we'll need this if we want to use that lint in <code>cargo fix --edition</code>.</p>
<p><span class="user-mention" data-user-id="119031">@Esteban Küber</span> <span class="user-mention" data-user-id="120518">@Eric Huss</span> <span class="user-mention" data-user-id="129356">@Zack M. Davis</span> <span class="user-mention" data-user-id="124288">@oli</span> (just some names i saw around that issue): do you think this is fixable within a few months, or will we have to change migration lints to only use one replacement?</p>



<a name="230358790"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/rustfix%20multi-span/near/230358790" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/rustfix.20multi-span.html#230358790">(Mar 15 2021 at 15:00)</a>:</h4>
<p>This is technically not hard to fix, I think it's mostly "blocked" on no one getting around to implementing one of the proposed solutions. That said, I won't be able to work on it or review it for the next few months.</p>



<a name="230360203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/rustfix%20multi-span/near/230360203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/rustfix.20multi-span.html#230360203">(Mar 15 2021 at 15:07)</a>:</h4>
<p><span class="user-mention" data-user-id="119031">@Esteban Küber</span> or <span class="user-mention" data-user-id="124288">@oli</span> do either of you think they would have time to mentor?</p>



<a name="230360258"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/rustfix%20multi-span/near/230360258" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/rustfix.20multi-span.html#230360258">(Mar 15 2021 at 15:08)</a>:</h4>
<p>I'm wndering if <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> wants to look at it :)</p>



<a name="230360357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/rustfix%20multi-span/near/230360357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/rustfix.20multi-span.html#230360357">(Mar 15 2021 at 15:08)</a>:</h4>
<p>We should definitely find someone to do it though</p>



<a name="230360378"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/rustfix%20multi-span/near/230360378" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/rustfix.20multi-span.html#230360378">(Mar 15 2021 at 15:08)</a>:</h4>
<p>I can help on the rustc side, we need to clean up the json output schema and I'm familiar with it</p>



<a name="230365171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/rustfix%20multi-span/near/230365171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/rustfix.20multi-span.html#230365171">(Mar 15 2021 at 15:35)</a>:</h4>
<p>I'm still not convinced any changes need to be made to rustc.  The only explanation I've seen for changing the JSON structure is some possibility of applying non-machine-applicable lints with a machine, which I don't understand.</p>



<a name="230532625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/rustfix%20multi-span/near/230532625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/rustfix.20multi-span.html#230532625">(Mar 16 2021 at 15:26)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/268952-edition-2021/topic/rustfix.20multi-span/near/230360258">said</a>:</p>
<blockquote>
<p>I'm wndering if <span class="user-mention silent" data-user-id="116266">Santiago Pastorino</span> wants to look at it :)</p>
</blockquote>
<p>sorry that I didn't answer yesterday but I'm not able right now</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>